Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add asset tests #215

Merged
merged 2 commits into from
Sep 27, 2024
Merged

test: add asset tests #215

merged 2 commits into from
Sep 27, 2024

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Sep 18, 2024 •
edited
Loading

Summary

Add assets test:

Some issues are not aligned or to be determined:

  1. Should remove __webpack_require__.p runtime in bundleless mode #219
  2. Import and export of assets in outputs #230
  3. [Feature]: generate seperate js for svgr in bundleless mode #231

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 marked this pull request as draft September 18, 2024 09:59
@netlify Netlify
Copy link

netlify bot commented Sep 18, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 8adf927
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/66f62ea8e18bbf000834071e
😎 Deploy Preview https://deploy-preview-215--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 force-pushed the test/asset branch 9 times, most recently from 01daadb to bf83e23 Compare September 24, 2024 09:45
@Timeless0911 Timeless0911 marked this pull request as ready for review September 24, 2024 10:00
@Timeless0911 Timeless0911 force-pushed the test/asset branch 2 times, most recently from 1f0c873 to 94b8c3a Compare September 26, 2024 04:13
@fi3ework fi3ework enabled auto-merge (squash) September 27, 2024 04:08
@fi3ework fi3ework merged commit 6d92cf4 into main Sep 27, 2024
10 checks passed
@fi3ework fi3ework deleted the test/asset branch September 27, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fi3ework fi3ework fi3ework approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timeless0911 @fi3ework